From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbbCIIXB (ORCPT ); Mon, 9 Mar 2015 04:23:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60610 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbbCIIW5 (ORCPT ); Mon, 9 Mar 2015 04:22:57 -0400 Date: Mon, 9 Mar 2015 09:22:53 +0100 From: Greg KH To: Zhang Zhen Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, tim.kryger@linaro.org, jamie@jamieiles.com, alan@linux.intel.com, arnd@arndb.de Subject: Re: [PATCH] serial: 8250: fix a sparse warning Message-ID: <20150309082253.GA14349@kroah.com> References: <1425886615-78601-1-git-send-email-zhenzhang.zhang@huawei.com> <54FD4EE6.7000408@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54FD4EE6.7000408@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 03:42:30PM +0800, Zhang Zhen wrote: > drivers/tty/serial/8250/8250_core.c: In function ‘serial8250_console_write’: > drivers/tty/serial/8250/8250_core.c:3244: warning: ‘flags’ may be used u > unitialized in this function > > Signed-off-by: Zhang Zhen > --- > drivers/tty/serial/8250/8250_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index deae122..50702e2 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -3241,7 +3241,7 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count) > { > struct uart_8250_port *up = &serial8250_ports[co->index]; > struct uart_port *port = &up->port; > - unsigned long flags; > + unsigned long flags = 0; > unsigned int ier; > int locked = 1; > Sparse generated this? Or did a broken / old version of gcc? This patch fixes nothing, sorry, so I can't accept it. greg k-h