From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752985AbbCIIad (ORCPT ); Mon, 9 Mar 2015 04:30:33 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:46380 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbbCIIaa (ORCPT ); Mon, 9 Mar 2015 04:30:30 -0400 Date: Mon, 9 Mar 2015 14:00:20 +0530 From: Sudip Mukherjee To: "Lad, Prabhakar" Cc: Tomi Valkeinen , Greg Kroah-Hartman , LFBDEV , OSUOSL Drivers , LKML Subject: Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print Message-ID: <20150309082956.GA9059@sudip-PC> References: <1425886506-8643-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 07:42:53AM +0000, Lad, Prabhakar wrote: > On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee > wrote: > > > > > > this patch will give checkpatch warnings about use of printk. > > this patch was mainly to fix the build warnings. printk will be > > converted to pr_* and dev_* in a later patch. > > > > + printk("lynxfb mmap pgoff: %lx\n", vma->vm_pgoff); > > + printk("lynxfb mmap off 1: %lx\n", off); > > > wouldn't it makes sense to change printk to some pr_*() ? yes, i could have. But usually Greg does not accept patches which is doing more than one type of change. That is why I mentioned in the comments that this will be converted to pr_* and dev_* in a later patch. regards sudip > > Cheers, > --Prabhakar Lad