From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbbCIIlL (ORCPT ); Mon, 9 Mar 2015 04:41:11 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:44619 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbbCIIlI (ORCPT ); Mon, 9 Mar 2015 04:41:08 -0400 Date: Mon, 9 Mar 2015 14:11:01 +0530 From: Sudip Mukherjee To: "Lad, Prabhakar" Cc: Greg Kroah-Hartman , LFBDEV , OSUOSL Drivers , LKML Subject: Re: [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Message-ID: <20150309084101.GB9059@sudip-PC> References: <1425886506-8643-1-git-send-email-sudipm.mukherjee@gmail.com> <1425886506-8643-3-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 07:47:40AM +0000, Lad, Prabhakar wrote: > On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee > wrote: > > check if it is already defined before defining SM750LE_REVISION_ID > > again and at the same time mention correct data type. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > v2: removed the redundant cast in sm750_hw.c > > > > drivers/staging/sm750fb/ddk750_chip.h | 4 +++- > > drivers/staging/sm750fb/sm750_hw.c | 2 +- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h > > index 1c78875..d761b72 100644 > > --- a/drivers/staging/sm750fb/ddk750_chip.h > > +++ b/drivers/staging/sm750fb/ddk750_chip.h > > @@ -1,7 +1,9 @@ > > #ifndef DDK750_CHIP_H__ > > #define DDK750_CHIP_H__ > > #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ > > -#define SM750LE_REVISION_ID (char)0xfe > > +#ifndef SM750LE_REVISION_ID > > +#define SM750LE_REVISION_ID ((unsigned char)0xfe) > > BTW who is defining this somewhere else ? it is defined in ddk750_chip.h which is again being used by ddk750_chip.c . regards sudip > > Cheers, > --Prabhakar Lad