From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matteo Semenzato <mattew8898@gmail.com>
Cc: gregkh@linuxfoundation.org, navin.patidar@gmail.com,
oat.elena@gmail.com, Larry.Finger@lwfinger.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock
Date: Mon, 9 Mar 2015 12:16:18 +0300 [thread overview]
Message-ID: <20150309091618.GA10964@mwanda> (raw)
In-Reply-To: <1425742407-6619-1-git-send-email-mattew8898@gmail.com>
Why is it a RESEND?
RESEND is a bit rude because it implies that we messed up by ignoring
your first email so you're sending us the exact same thing again.
Sometimes rudeness is valid if people are ignoring good patches but you
send the first email 4 minutes before sending the second email.
On Sat, Mar 07, 2015 at 04:33:27PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
No need for this, we can get it from your email.
>
> The rtw_cmd_thread semaphore was being unlocked twice.
This patch is probably correct, but it's a bit risky without testing or
further analysis. Please explain how you verified that it won't cause
a deadlock.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-09 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 15:33 [PATCH RESEND] Staging: rtl8188eu: fix double unlock Matteo Semenzato
2015-03-07 17:28 ` Larry Finger
2015-03-07 17:35 ` Matteo Semenzato
2015-03-07 17:44 ` Larry Finger
2015-03-09 9:16 ` Dan Carpenter [this message]
2015-03-09 14:21 ` Matteo Semenzato
2015-03-09 14:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309091618.GA10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattew8898@gmail.com \
--cc=navin.patidar@gmail.com \
--cc=oat.elena@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox