From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbbCIJQk (ORCPT ); Mon, 9 Mar 2015 05:16:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50729 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753838AbbCIJQh (ORCPT ); Mon, 9 Mar 2015 05:16:37 -0400 Date: Mon, 9 Mar 2015 12:16:18 +0300 From: Dan Carpenter To: Matteo Semenzato Cc: gregkh@linuxfoundation.org, navin.patidar@gmail.com, oat.elena@gmail.com, Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock Message-ID: <20150309091618.GA10964@mwanda> References: <1425742407-6619-1-git-send-email-mattew8898@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425742407-6619-1-git-send-email-mattew8898@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Why is it a RESEND? RESEND is a bit rude because it implies that we messed up by ignoring your first email so you're sending us the exact same thing again. Sometimes rudeness is valid if people are ignoring good patches but you send the first email 4 minutes before sending the second email. On Sat, Mar 07, 2015 at 04:33:27PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato No need for this, we can get it from your email. > > The rtw_cmd_thread semaphore was being unlocked twice. This patch is probably correct, but it's a bit risky without testing or further analysis. Please explain how you verified that it won't cause a deadlock. regards, dan carpenter