Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

Dan Carpenter
2015-03-09T09:16:40Z

Why is it a RESEND?

RESEND is a bit rude because it implies that we messed up by ignoring
your first email so you're sending us the exact same thing again.
Sometimes rudeness is valid if people are ignoring good patches but you
send the first email 4 minutes before sending the second email.

On Sat, Mar 07, 2015 at 04:33:27PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>

No need for this, we can get it from your email.

>
> The rtw_cmd_thread semaphore was being unlocked twice.

This patch is probably correct, but it's a bit risky without testing or
further analysis. Please explain how you verified that it won't cause
a deadlock.

regards,
dan carpenter