From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753883AbbCIJdj (ORCPT ); Mon, 9 Mar 2015 05:33:39 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37853 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753448AbbCIJdh (ORCPT ); Mon, 9 Mar 2015 05:33:37 -0400 Date: Mon, 9 Mar 2015 09:33:32 +0000 From: Lee Jones To: Raymond Tan Cc: Mike Turquette , Samuel Ortiz , linux-kernel@vger.kernel.org, Alvin Chen , Andriy Shevchenko Subject: Re: [PATCH v4 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver Message-ID: <20150309093332.GD3427@x1> References: <1422845571-7616-1-git-send-email-raymond.tan@intel.com> <1422845571-7616-2-git-send-email-raymond.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1422845571-7616-2-git-send-email-raymond.tan@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Feb 2015, Raymond Tan wrote: > In Quark X1000, there's a single PCI device that provides both > an I2C controller and a GPIO controller. This MFD driver will > split the 2 devices for their respective drivers. > > This patch is based on Josef Ahmad's initial work for Quark enabling. > > Acked-by: Michael Turquette > Reviewed-by: Andy Shevchenko > Signed-off-by: Weike Chen > Signed-off-by: Raymond Tan > --- > drivers/mfd/Kconfig | 12 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/intel_quark_i2c_gpio.c | 277 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 290 insertions(+) > create mode 100644 drivers/mfd/intel_quark_i2c_gpio.c Hopefully all of my review comments have been tended to. Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog