From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbbCIJlC (ORCPT ); Mon, 9 Mar 2015 05:41:02 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:34196 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbbCIJk5 (ORCPT ); Mon, 9 Mar 2015 05:40:57 -0400 Date: Mon, 9 Mar 2015 09:40:50 +0000 From: Lee Jones To: gyungoh@gmail.com Cc: sameo@linux.intel.com, robh+dt@kernel.org, jg1.han@samsung.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, trivial@kernel.org, broonie@kernel.org, florian.vaussard@epfl.ch, andrew@lunn.ch, antonynpavlov@gmail.com, hytszk@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, treding@nvidia.com, p.zabel@pengutronix.de, arno@natisbad.org, kuninori.morimoto.gx@renesas.com Subject: Re: [PATCH v11 4/6] devicetree: Add new SKY81452 backlight binding Message-ID: <20150309094050.GO3427@x1> References: <1425019346-4559-1-git-send-email-jack.yoo@skyworksinc.com> <1425019346-4559-5-git-send-email-jack.yoo@skyworksinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425019346-4559-5-git-send-email-jack.yoo@skyworksinc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 27 Feb 2015, gyungoh@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > Acked-by: Bryan Wu > --- > Changes v11: > Renamed 'skyworks,en-channels' property to led-sources. > Removed unused property 'skyworks,ovp-level'. > > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable property to generic property for GPIO > Made up the example for backlight DT > > Changes v7: > Nothing > > Changes v6: > Nothing > > Changes v5: > Nothing > > Changes v4: > Nothing > > Changes v3: > Nothing > > Changes v2: > Added reg attribute for I2C slave address > > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > new file mode 100644 > index 0000000..8bf2940 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > @@ -0,0 +1,29 @@ > +SKY81452-backlight bindings > + > +Required properties: > +- compatible : Must be "skyworks,sky81452-backlight" > + > +Optional properties: > +- name : Name of backlight device. Default is 'lcd-backlight'. > +- gpios : GPIO to use to EN pin. > + See Documentation/devicetree/bindings/gpio/gpio.txt > +- led-sources : List of enabled channels from 0 to 5. > + See Documentation/devicetree/bindings/leds/common.txt > +- skyworks,ignore-pwm : Ignore both PWM input > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. > +- skyworks,phase-shift : Enable phase shift mode > +- skyworks,short-detection-threshold-volt > + : It should be one of 4, 5, 6 and 7V. > +- skyworks,current-limit-mA > + : It should be 2300mA or 2750mA. > + > +Example: > + > + backlight { > + compatible = "skyworks,sky81452-backlight"; > + name = "pwm-backlight"; > + led-sources = <0 1 2 5>; > + skyworks,ignore-pwm; > + skyworks,phase-shift; > + skyworks,current-limit-mA = <2300>; > + }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog