From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753064AbbCILKG (ORCPT ); Mon, 9 Mar 2015 07:10:06 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36776 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbbCILKD (ORCPT ); Mon, 9 Mar 2015 07:10:03 -0400 Date: Mon, 9 Mar 2015 12:09:58 +0100 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Jiri Olsa , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Rabin Vincent Subject: Re: [PATCH 1/1] perf annotate: Fix fallback to unparsed disassembler line Message-ID: <20150309110957.GA12201@gmail.com> References: <1425582200-28125-1-git-send-email-acme@kernel.org> <1425582200-28125-2-git-send-email-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425582200-28125-2-git-send-email-acme@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > [...] > > Further investigation is needed to figure out the nature of the > objdump output change so as to make the parser grok it. Btw., maybe someone finds this interesting: we could also (re-)use the in-kernel disassembler (on x86 and any other architecture that might have one), which used by live patching facilities (kprobes et al). See arch/x86/lib/insn.c. The 'visualization' bit is missing entirely: but it does a lot of the hard work of knowing about the instruction format: it knows about essentially all x86 instructions and is able to determine instruction boundaries, and can decode immediate constants. Using this in tools/perf/ would have the added advantage that we could then use the dissasembly in kernel oops output (nice feature!) - plus tooling folks would help us fix and extend the kernel's disassembler! ;-) Thanks, Ingo