From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbbCILx5 (ORCPT ); Mon, 9 Mar 2015 07:53:57 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36650 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbbCILxx (ORCPT ); Mon, 9 Mar 2015 07:53:53 -0400 Date: Mon, 9 Mar 2015 14:53:37 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Tomi Valkeinen , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print Message-ID: <20150309115337.GD10964@mwanda> References: <1425886506-8643-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425886506-8643-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote: > mention correct format specifier while printing. > fixes all the build warnings about incorrect argument type while > printing. > > Signed-off-by: Sudip Mukherjee > --- > > V2: Giedrius commented resource_size_t can be either u64 or u32 > depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i > should have kept the datatype as resource_size_t and used %pa as the > format specifier. But since this is a framebuffer device and it > should follow what the framebuffer layer is suggesting in > struct fb_fix_screeninfo at smem_start and mmio_start. > adding Tomi for his comments. This should all have gone into the changelog because it changes how the code works. regards, dan carpenter