From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbbCIMml (ORCPT ); Mon, 9 Mar 2015 08:42:41 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20167 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbbCIMmj (ORCPT ); Mon, 9 Mar 2015 08:42:39 -0400 Date: Mon, 9 Mar 2015 15:42:22 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function Message-ID: <20150309124222.GE10964@mwanda> References: <1425886506-8643-1-git-send-email-sudipm.mukherjee@gmail.com> <1425886506-8643-4-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425886506-8643-4-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote: > kbuild test robot reported that for microblaze-allyesconfig > chan_to_field() and lynxfb_ops_set_par() were not defined. These two > functions were defined under CONFIG_PM, so for any archtecture if > CONFIG_PM is not defined we will have this error. > > while moving the lynxfb_suspend() function some very obvious > checkpatch errors, like space after comma, space after if, space > before opening brace, were taken care of. I have a script to review patches moving functions around but these white space changes break my script so I have to review it by hand. Sucks. > static int lynxfb_ops_set_par(struct fb_info * info) > { > struct lynxfb_par * par; > @@ -369,7 +313,6 @@ static int lynxfb_ops_set_par(struct fb_info * info) > struct fb_fix_screeninfo * fix; > int ret; > unsigned int line_length; > - > > if(!info) > return -EINVAL; > @@ -441,6 +384,7 @@ static int lynxfb_ops_set_par(struct fb_info * info) > ret = output->proc_setMode(output,var,fix); > return ret; > } > + > static inline unsigned int chan_to_field(unsigned int chan,struct fb_bitfield * bf) > { > chan &= 0xffff; These white space changes are not related. regards, dan carpenter