From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbbCINCv (ORCPT ); Mon, 9 Mar 2015 09:02:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51239 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751443AbbCINCt (ORCPT ); Mon, 9 Mar 2015 09:02:49 -0400 Date: Mon, 9 Mar 2015 14:02:46 +0100 From: Antoine Tenart To: Axel Lin Cc: Kishon Vijay Abraham I , Antoine Tenart , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] phy: berlin-sata: Use devm_kcalloc at appropriate place Message-ID: <20150309130246.GA8421@kwain> References: <1425519641.1637.2.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425519641.1637.2.camel@phoenix> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 09:40:41AM +0800, Axel Lin wrote: > Prefer devm_kcalloc over devm_kzalloc with multiply. > > Signed-off-by: Axel Lin Acked-by: Antoine Tenart > --- > drivers/phy/phy-berlin-sata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-sata.c > index 099eee8..6f3e06d 100644 > --- a/drivers/phy/phy-berlin-sata.c > +++ b/drivers/phy/phy-berlin-sata.c > @@ -218,7 +218,7 @@ static int phy_berlin_sata_probe(struct platform_device *pdev) > if (priv->nphys == 0) > return -ENODEV; > > - priv->phys = devm_kzalloc(dev, priv->nphys * sizeof(*priv->phys), > + priv->phys = devm_kcalloc(dev, priv->nphys, sizeof(*priv->phys), > GFP_KERNEL); > if (!priv->phys) > return -ENOMEM; > -- > 1.9.1 > > > -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com