From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbbCINiZ (ORCPT ); Mon, 9 Mar 2015 09:38:25 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27553 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbbCINiX (ORCPT ); Mon, 9 Mar 2015 09:38:23 -0400 Date: Mon, 9 Mar 2015 16:38:05 +0300 From: Dan Carpenter To: Sudip Mukherjee , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: sm7xxfb: change return of sm7xx_vga_setup Message-ID: <20150309133805.GI10964@mwanda> References: <1425836411-15481-1-git-send-email-sudipm.mukherjee@gmail.com> <1425836411-15481-3-git-send-email-sudipm.mukherjee@gmail.com> <20150309131343.GG10964@mwanda> <20150309133032.GA13002@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309133032.GA13002@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 07:00:33PM +0530, Sudip Mukherjee wrote: > On Mon, Mar 09, 2015 at 04:13:43PM +0300, Dan Carpenter wrote: > > On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote: > > > change return type of sm7xx_vga_setup() to void as we are not using > > > the return type anywhere. if this function fails we fall back to the > > > default configuration. > > > > > > Signed-off-by: Sudip Mukherjee > > > > Reviewed-by: Dan Carpenter > > > > This patch is fine but if you wanted you could send a follow on which > > set it to SCREEN_X_RES, SCREEN_Y_RES, SCREEN_BPP if there were no > > options. Then remove the "if (smtc_scr_info.lfb_width != 0) " condition > > in smtcfb_pci_probe(). > > yes, i could have. But actually I am thinking to totally remove this function and use more conventional fb_get_mode() in its places. But if i do so then the boot parameters will change. Currently it is like vga=sm712fb:0x301 but if i change it to use fb_get_mode() then the boot parameters will change to vga=sm712fb:640x480@60-8 , and that is why I am hesitating. But it will be more conventional to what all framebuffer drivers follows. > Hm... That's a good question. I suspect we should just go with fb_get_mode() and do it quickly. This driver is so new in the kernel that there are no users to get upset. regards, dan carpenter