From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbbCIQ3P (ORCPT ); Mon, 9 Mar 2015 12:29:15 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:42439 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754158AbbCIQ3M (ORCPT ); Mon, 9 Mar 2015 12:29:12 -0400 Date: Mon, 9 Mar 2015 17:29:08 +0100 From: Ingo Molnar To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt , Denys Vlasenko , Shuah Khan , Borislav Petkov Subject: Re: [PATCH] x86, selftests: Add sigreturn_32 selftest Message-ID: <20150309162908.GA22895@gmail.com> References: <0ab957716f8bfca562bac3134f2aabe8156cf0c0.1425917146.git.luto@amacapital.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ab957716f8bfca562bac3134f2aabe8156cf0c0.1425917146.git.luto@amacapital.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Lutomirski wrote: > This is my sigreturn test, added mostly unchanged from its old home. > > The integration with the selftest build process seems okay if not > particularly elegant. > > I'm not using the ksft_ helpers at all yet. I can do that later. Cool! Doesn't seem to build on Ubuntu though: make[1]: Entering directory '/home/mingo/tip/tools/testing/selftests/x86' gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall sigreturn.c -lrt -ldl sigreturn.c:13:22: fatal error: sys/time.h: No such file or directory #include ^ compilation terminated. Makefile:18: recipe for target 'sigreturn_32' failed also, run_tests.sh probably wants to be executable? Thanks, Ingo