From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753910AbbCIQzF (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 12:55:05 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43309 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750830AbbCIQzA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 12:55:00 -0400
Date: Mon, 9 Mar 2015 17:53:38 +0100
From: Borislav Petkov <bp@suse.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Dave Hansen <dave.hansen@intel.com>, Ingo Molnar <mingo@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Pekka Riikonen <priikone@iki.fi>, Rik van Riel <riel@redhat.com>,
        Suresh Siddha <sbsiddha@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>
Subject: Re: [PATCH 1/1] x86/fpu: x86/fpu: avoid math_state_restore() without
 used_math() in __restore_xstate_sig()
Message-ID: <20150309165338.GF12732@pd.tnic>
References: <54F74F59.5070107@intel.com>
 <20150305195127.GA12657@redhat.com>
 <20150307153824.GA25954@redhat.com>
 <20150307153844.GB25954@redhat.com>
 <20150309140712.GB12732@pd.tnic>
 <20150309143436.GA3526@redhat.com>
 <20150309151837.GC12732@pd.tnic>
 <20150309162404.GA7833@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150309162404.GA7833@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 09, 2015 at 05:24:04PM +0100, Oleg Nesterov wrote:
> Well, this is the same thinhg reported by Dave ;)

Am I the only one in thinking that this FPU thing went completely nuts?!
Just kill it all and let's start from scratch. :-P

> It is not fixed by Quentin's patch.
> 
> This patch "fixes" the problem in a sense that the kernel won't crash
> after restore_fpu_checking() triggers #GP. Before this patch
> do_general_protection()->fixup_exception() does not work in this case
> and the kernel panics.
> 
> But restore_fpu_checking() should not trigger #GP (and fail).

Right.

...

> But this too doesn't fix the problem: fpu_finit() is buggy on Dave's
> machine.

In talking about fpu_finit() - I still have two cleanup patches queued
from you:

http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=tip-x86-fpu-2

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--