From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753928AbbCISIy (ORCPT ); Mon, 9 Mar 2015 14:08:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51766 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbbCISIx (ORCPT ); Mon, 9 Mar 2015 14:08:53 -0400 Date: Mon, 9 Mar 2015 19:06:47 +0100 From: Oleg Nesterov To: Borislav Petkov Cc: Dave Hansen , Ingo Molnar , Andy Lutomirski , Linus Torvalds , Pekka Riikonen , Rik van Riel , Suresh Siddha , LKML , "Yu, Fenghua" , Quentin Casasnovas Subject: Re: [PATCH] x86/fpu: drop_fpu() should not assume that tsk == current Message-ID: <20150309180646.GA14028@redhat.com> References: <54F74F59.5070107@intel.com> <20150309171041.GB11388@redhat.com> <20150309174825.GH12732@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309174825.GH12732@pd.tnic> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09, Borislav Petkov wrote: > > On Mon, Mar 09, 2015 at 06:10:41PM +0100, Oleg Nesterov wrote: > > drop_fpu() does clear_used_math() and usually this is correct because > > tsk == current. However switch_fpu_finish()->restore_fpu_checking() is > > called before it updates the "current_task" variable. If it fails, we > > You mean here "... before __switch_to() updates the current_task ... ", > I assume? Yes... should I resend? Oleg.