From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbbCJGpQ (ORCPT ); Tue, 10 Mar 2015 02:45:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28757 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbbCJGpJ (ORCPT ); Tue, 10 Mar 2015 02:45:09 -0400 Date: Tue, 10 Mar 2015 09:44:40 +0300 From: Dan Carpenter To: Matteo Semenzato Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: fix information leak Message-ID: <20150310064440.GK10964@mwanda> References: <1425931697-10301-1-git-send-email-mattew8898@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425931697-10301-1-git-send-email-mattew8898@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 09:08:17PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > The comedi_cmd struct has an hole after chanlist_len that could contain uninitialized > memory, this struct is copied to userspace. > Is this a Smatch warning? If so then, I appologize because it's a false positive. You really need to have the cross function database built for that test to work. The struct is initialized in __comedi_get_user_cmd(). regards, dan carpenter