From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbbCJGwM (ORCPT ); Tue, 10 Mar 2015 02:52:12 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:31771 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbbCJGwH (ORCPT ); Tue, 10 Mar 2015 02:52:07 -0400 Date: Tue, 10 Mar 2015 09:51:46 +0300 From: Dan Carpenter To: markh@compro.net Cc: Matteo Semenzato , gregkh@linuxfoundation.org, lidza.louina@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: dgnc: fix bitmask Message-ID: <20150310065146.GL10964@mwanda> References: <1425932078-16221-1-git-send-email-mattew8898@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425932078-16221-1-git-send-email-mattew8898@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > The bitmask should be used on msignals since the signals variable is not > used anywhere in the function. > You're probably right. I would really like to get Mark's Ack on this though becuase it's sort of a guess and not tested. regards, dan carpenter > Signed-off-by: Matteo Semenzato > --- > drivers/staging/dgnc/dgnc_cls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c > index bedc522..29c6316 100644 > --- a/drivers/staging/dgnc/dgnc_cls.c > +++ b/drivers/staging/dgnc/dgnc_cls.c > @@ -1137,7 +1137,7 @@ static void cls_parse_modem(struct channel_t *ch, unsigned char signals) > * Scrub off lower bits. They signify delta's, which I don't > * care about > */ > - signals &= 0xf0; > + msignals &= 0xf0; > > spin_lock_irqsave(&ch->ch_lock, flags); > if (msignals & UART_MSR_DCD) > -- > 2.3.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel