From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbbCJLky (ORCPT ); Tue, 10 Mar 2015 07:40:54 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20632 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbbCJLkw (ORCPT ); Tue, 10 Mar 2015 07:40:52 -0400 Date: Tue, 10 Mar 2015 14:40:30 +0300 From: Dan Carpenter To: Lorenzo Stoakes Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750 Message-ID: <20150310114030.GP10964@mwanda> References: <1425981426-20680-1-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425981426-20680-1-git-send-email-lstoakes@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 09:57:06AM +0000, Lorenzo Stoakes wrote: > This patch assigns the more appropriate void* type to the mmio750 variable > eliminating an unnecessary volatile qualifier in the process. Additionally it > updates parameter types as necessary where those parameters interact with > mmio750 and removes unnecessary casts. > > As a consequence, this patch fixes the following sparse warning:- > > drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces) > > Signed-off-by: Lorenzo Stoakes Looks good. Thanks for doing this. regards, dan carpenter