From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753501AbbCJO1w (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Mar 2015 10:27:52 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45788 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751391AbbCJO1v (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Mar 2015 10:27:51 -0400
Date: Tue, 10 Mar 2015 15:26:27 +0100
From: Borislav Petkov <bp@suse.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andre Przywara <Andre.Przywara@arm.com>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3] x86: move cacheinfo sysfs to generic cacheinfo
 infrastructure
Message-ID: <20150310142627.GF3535@pd.tnic>
References: <1424715265-21407-1-git-send-email-sudeep.holla@arm.com>
 <1425470416-20691-1-git-send-email-sudeep.holla@arm.com>
 <20150304122720.GD3663@pd.tnic>
 <20150305081640.GA3817@pd.tnic>
 <54F821D8.4030605@arm.com>
 <20150310113707.GE3535@pd.tnic>
 <54FEDB3F.4080007@arm.com>
 <54FEFE1E.1070901@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <54FEFE1E.1070901@arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 10, 2015 at 02:22:22PM +0000, Sudeep Holla wrote:
> I was able to reproduce this and now I realise I had CONFIG_AMD_NB
> disabled in my config earlier which hid this issue previously, sorry
> for that.
> 
> The below patch fixed the issue on my Intel i7 box. I can post this
> separately if required.
> 
> Regards,
> Sudeep
> 
> From b081cbf26071f4c8ce51f270931387415ab1a06c Mon Sep 17 00:00:00 2001
> From: Sudeep Holla <sudeep.holla@arm.com>
> Date: Tue, 10 Mar 2015 13:49:58 +0000
> Subject: [PATCH] x86: cacheinfo: fix cache_get_priv_group for Intel
> processors
> 
> The private pointer provided by the cacheinfo is used to implement
> the AMD L3 cache specific attributes using the northbridge pointer
> obtained through cpuid4 registers. However, it's populated even on
> Intel processors for Level 3 cache. This results in failure of

Do we need it populated on Intel?

Because if not, we can leave it NULL there and do only

	if (this_leaf->level < 3 || !nb)
		return NULL;

No?

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--