From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbbCJPFA (ORCPT ); Tue, 10 Mar 2015 11:05:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53231 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbCJPE7 (ORCPT ); Tue, 10 Mar 2015 11:04:59 -0400 Date: Tue, 10 Mar 2015 16:04:54 +0100 From: Greg KH To: Lorenzo Stoakes Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750 Message-ID: <20150310150454.GA22451@kroah.com> References: <1425981426-20680-1-git-send-email-lstoakes@gmail.com> <20150310114030.GP10964@mwanda> <20150310123633.GA2782@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 12:47:44PM +0000, Lorenzo Stoakes wrote: > On 10 March 2015 at 12:36, Sudip Mukherjee wrote: > > but it is introducing two new build warnings: > > > > drivers/staging/sm750fb/sm750_hw.c: In function ‘hw_sm750_map’: > > drivers/staging/sm750fb/sm750_hw.c:67:2: warning: passing argument 1 of ‘ddk750_set_mmio’ discards ‘volatile’ qualifier from pointer target type [enabled by default] > > In file included from drivers/staging/sm750fb/ddk750_mode.h:4:0, > > from drivers/staging/sm750fb/ddk750.h:15, > > from drivers/staging/sm750fb/sm750_hw.c:24: > > > > and > > > > drivers/staging/sm750fb/ddk750_chip.h:77:6: note: expected ‘void *’ but argument is of type ‘volatile unsigned char *’ > > > > care to make another patch to solve these two new warnings, and send this patch and the new one in a series and while sending mark the version number in the subject. > > I think the second warning is simply additional information attached > to the 1st to give context? > > I noticed this issue but felt changing the type of this field would > sit outside the purview of this patch as then I'm not only changing > the type of mmio750 and code that *directly* interacts with this > variable, but also code that indirectly interacts with it, so I felt > that should perhaps be a separate patch. > > I'd love to additionally provide some further patches to help out with > issues here too, incidentally! I will try to prepare some further > patches tonight in this vein. I can't apply patches that add new build warnings, sorry. Please fix this up in the patch itself. greg k-h