From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbbCJPIY (ORCPT ); Tue, 10 Mar 2015 11:08:24 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59196 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753358AbbCJPIT (ORCPT ); Tue, 10 Mar 2015 11:08:19 -0400 X-Sasl-enc: RgcaEbxPRvJwaV+8OMbN8t4XTeSJKI0hncA0i554BaOU 1426000098 Date: Tue, 10 Mar 2015 16:08:15 +0100 From: Greg KH To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: Re: linux-next: build failure after merge of the staging tree Message-ID: <20150310150815.GA28071@kroah.com> References: <20150310160728.7213b9fa@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150310160728.7213b9fa@canb.auug.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 04:07:28PM +1100, Stephen Rothwell wrote: > Hi Greg, > > After merging the staging tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file included from include/linux/module.h:17:0, > from drivers/staging/sm750fb/sm750.c:2: > drivers/staging/sm750fb/sm750.c: In function '__check_g_option': > drivers/staging/sm750fb/sm750.c:1436:14: error: 'g_option' undeclared (first use in this function) > module_param(g_option,charp,S_IRUGO); > ^ > > Caused by commit 81dee67e215b ("staging: sm750fb: add sm750 to staging"). > > This driver also produced a large number of warnings ... a lot like this: > > drivers/staging/sm750fb/sm750.c: In function 'lynxfb_ops_mmap': > drivers/staging/sm750fb/sm750.c:533:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] > printk("lynxfb mmap pgoff: %x\n", vma->vm_pgoff); > ^ > > Also note: > > In file included from drivers/staging/sm750fb/ddk750_mode.h:4:0, > from drivers/staging/sm750fb/ddk750.h:15, > from drivers/staging/sm750fb/sm750_hw.c:24: > drivers/staging/sm750fb/ddk750_chip.h:4:0: warning: "SM750LE_REVISION_ID" redefined > #define SM750LE_REVISION_ID (char)0xfe > ^ > In file included from drivers/staging/sm750fb/sm750_hw.c:23:0: > drivers/staging/sm750fb/sm750_hw.h:8:0: note: this is the location of the previous definition > #define SM750LE_REVISION_ID (unsigned char)0xfe > ^ > > I have disabled this driver for now, please let me know when it is OK > to enable it again. Sorry about that. Yes, I know it's a mess. The build error on ppc should now be fixed in my tree. The build warnings are still there (some are gone). I should just go fix them up myself, and will do so tonight if I don't get a patch from someone else that does so first... So it should be safe to enable again. thanks, greg k-h