From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398AbbCJPOE (ORCPT ); Tue, 10 Mar 2015 11:14:04 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:41979 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbbCJPOA (ORCPT ); Tue, 10 Mar 2015 11:14:00 -0400 Date: Tue, 10 Mar 2015 15:13:54 +0000 From: Lee Jones To: Dmitry Torokhov Cc: Tony Lindgren , Samuel Ortiz , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: menelaus: rmove incorrect __exit markups Message-ID: <20150310151354.GA3342@x1> References: <20150309174936.GA22662@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150309174936.GA22662@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Mar 2015, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov > --- > drivers/mfd/menelaus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c > index 9f01aef..5269ff2 100644 > --- a/drivers/mfd/menelaus.c > +++ b/drivers/mfd/menelaus.c > @@ -1259,7 +1259,7 @@ fail: > return err; > } > > -static int __exit menelaus_remove(struct i2c_client *client) > +static int menelaus_remove(struct i2c_client *client) > { > struct menelaus_chip *menelaus = i2c_get_clientdata(client); > > @@ -1280,7 +1280,7 @@ static struct i2c_driver menelaus_i2c_driver = { > .name = DRIVER_NAME, > }, > .probe = menelaus_probe, > - .remove = __exit_p(menelaus_remove), > + .remove = menelaus_remove, > .id_table = menelaus_id, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog