From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbbCJQK4 (ORCPT ); Tue, 10 Mar 2015 12:10:56 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51962 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbbCJQKz (ORCPT ); Tue, 10 Mar 2015 12:10:55 -0400 Date: Tue, 10 Mar 2015 17:10:49 +0100 From: Sascha Hauer To: Russell King - ARM Linux Cc: Matthias Brugger , YH Chen , linux-kernel@vger.kernel.org, Henry Chen , Flora Fu , linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Yingjoe Chen , Eddie Huang , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] soc: mediatek: Add PMIC wrapper for MT8135 and MT8173 SoCs Message-ID: <20150310161049.GI24885@pengutronix.de> References: <1426000954-7647-1-git-send-email-s.hauer@pengutronix.de> <1426000954-7647-3-git-send-email-s.hauer@pengutronix.de> <20150310154610.GP8656@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150310154610.GP8656@n2100.arm.linux.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:05:29 up 1 day, 7:26, 52 users, load average: 0.64, 0.51, 0.74 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 03:46:11PM +0000, Russell King - ARM Linux wrote: > On Tue, Mar 10, 2015 at 04:22:34PM +0100, Sascha Hauer wrote: > > + for (i = 0; i < 4; i++) { > > + pwrap_writel(wrp, i, PWRAP_SIDLY); > > + pwrap_read(wrp, PWRAP_DEW_READ_TEST, &rdata); > > + printk("%s: 0x%04x\n", __func__, rdata); > > Is this really ready for submission, or is this just a hidden oversight? > > What I tend to do with such debugging is _not_ to indent it at all, which > means when the file is reviewed before sending it out (or indeed, when > diffing it to review the updates before committing those changes or an > amendment to the previous commit) that it sticks out like a sore thumb. I often do this aswell, apparently not all the time :-/ This message is also not seen often during booting since the driver has this in it: /* * The PMIC could already be initialized by the bootloader. * Skip initialization here in this case. */ if (!pwrap_readl(wrp, PWRAP_INIT_DONE2)) { ret = pwrap_init(wrp); if (ret) { dev_dbg(wrp->dev, "init failed with %d\n", ret); goto err_out2; } } I first have to comment out the already initialized check to see this message. I just rechecked, yes, the initialisation still works as expected. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |