From: Pavel Machek <pavel@ucw.cz>
To: Joe Xue <lgxue@hotmail.com>
Cc: "Bryan Wu" <cooloney@gmail.com>,
"Raphaël Teysseyre" <rteysseyre@gmail.com>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"Linux LED Subsystem" <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] leds: Add status code trigger
Date: Tue, 10 Mar 2015 20:22:26 +0100 [thread overview]
Message-ID: <20150310192226.GB11260@amd> (raw)
In-Reply-To: <BLU172-W3716E59BC9E98F60F424C4AC180@phx.gbl>
Hi!
> This patch is very similar to mine patten trigger and all features are covered by my patch.
> If you are considering to take this feature, could you consider my patch instead?
> http://thread.gmane.org/gmane.linux.documentation/19116/focus=19135
That one is indeed better than this patch (as it supports almost
arbitrary blinking pattern on single LED, it will not help much with
smooth brightness control.
Would solution below work for you?
Best regards,
Pavel
> > I think I have interface to handle most of the issues: array of
> > integers in "brightness, length in miliseconds".
> >
> > So for example slowly blinking LED would be "0 1000msec, 255 1000
> > msec". On off pattern would be "0 1000msec, 255 0msec, 255 1000msec, 0
> > 0msec".
> >
> > Rapahael, this should be able to do all the stuff you want to do. It
> > can also do morse code, slow blinks, and combination of both. Do you
> > want to try implementing it?
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-03-10 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1424334377.11286.3.camel@localhost>
2015-03-09 21:15 ` [PATCH RFC] leds: Add status code trigger Bryan Wu
2015-03-10 8:00 ` Pavel Machek
[not found] ` <BLU172-W3716E59BC9E98F60F424C4AC180@phx.gbl>
2015-03-10 19:22 ` Pavel Machek [this message]
2015-03-11 15:10 ` Raphaël Teysseyre
2015-03-11 19:02 ` Pavel Machek
2015-03-12 6:56 ` Raphaël Teysseyre
2015-03-16 10:06 ` [PATCH] leds: Add arbitrary pattern trigger Raphaël Teysseyre
2015-03-16 11:55 ` Pavel Machek
2015-03-16 16:49 ` Raphaël Teysseyre
2015-03-16 12:20 ` Pavel Machek
2015-03-16 12:40 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310192226.GB11260@amd \
--to=pavel@ucw.cz \
--cc=cooloney@gmail.com \
--cc=lgxue@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).