From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbbCJTWc (ORCPT ); Tue, 10 Mar 2015 15:22:32 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36415 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753276AbbCJTW3 (ORCPT ); Tue, 10 Mar 2015 15:22:29 -0400 Date: Tue, 10 Mar 2015 20:22:26 +0100 From: Pavel Machek To: Joe Xue Cc: Bryan Wu , =?iso-8859-1?Q?Rapha=EBl?= Teysseyre , "rpurdie@rpsys.net" , Linux LED Subsystem , lkml Subject: Re: [PATCH RFC] leds: Add status code trigger Message-ID: <20150310192226.GB11260@amd> References: <1424334377.11286.3.camel@localhost> <20150310080042.GA27585@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > This patch is very similar to mine patten trigger and all features are covered by my patch. > If you are considering to take this feature, could you consider my patch instead? > http://thread.gmane.org/gmane.linux.documentation/19116/focus=19135 That one is indeed better than this patch (as it supports almost arbitrary blinking pattern on single LED, it will not help much with smooth brightness control. Would solution below work for you? Best regards, Pavel > > I think I have interface to handle most of the issues: array of > > integers in "brightness, length in miliseconds". > > > > So for example slowly blinking LED would be "0 1000msec, 255 1000 > > msec". On off pattern would be "0 1000msec, 255 0msec, 255 1000msec, 0 > > 0msec". > > > > Rapahael, this should be able to do all the stuff you want to do. It > > can also do morse code, slow blinks, and combination of both. Do you > > want to try implementing it? > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html