From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mitchel Humpherys <mitchelh@codeaurora.org>
Cc: devel@linuxdriverproject.org,
Android Kernel Team <kernel-team@android.com>,
Colin Cross <ccross@android.com>,
John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ion: improve ion_phys error message
Date: Tue, 10 Mar 2015 23:46:29 +0300 [thread overview]
Message-ID: <20150310204629.GR10964@mwanda> (raw)
In-Reply-To: <1426007328-3288-1-git-send-email-mitchelh@codeaurora.org>
On Tue, Mar 10, 2015 at 10:08:48AM -0700, Mitchel Humpherys wrote:
> Clients often get confused when ion_phys errors out due to some heap
> being used that they didn't expect. Add the heap name and heap type to
> the error message to make it more obvious.
>
> Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Hm... You sent this exact same patch a month ago. I'm not sure what
went wrong. You should probably CC Greg next time. It looks ok to me.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-10 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 17:08 [PATCH] ion: improve ion_phys error message Mitchel Humpherys
2015-03-10 20:46 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-02-14 2:05 Mitchel Humpherys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310204629.GR10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ccross@android.com \
--cc=devel@linuxdriverproject.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox