From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbbCJUqr (ORCPT ); Tue, 10 Mar 2015 16:46:47 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43179 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbbCJUqp (ORCPT ); Tue, 10 Mar 2015 16:46:45 -0400 Date: Tue, 10 Mar 2015 23:46:29 +0300 From: Dan Carpenter To: Mitchel Humpherys Cc: devel@linuxdriverproject.org, Android Kernel Team , Colin Cross , John Stultz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ion: improve ion_phys error message Message-ID: <20150310204629.GR10964@mwanda> References: <1426007328-3288-1-git-send-email-mitchelh@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426007328-3288-1-git-send-email-mitchelh@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 10:08:48AM -0700, Mitchel Humpherys wrote: > Clients often get confused when ion_phys errors out due to some heap > being used that they didn't expect. Add the heap name and heap type to > the error message to make it more obvious. > > Signed-off-by: Mitchel Humpherys Hm... You sent this exact same patch a month ago. I'm not sure what went wrong. You should probably CC Greg next time. It looks ok to me. Reviewed-by: Dan Carpenter regards, dan carpenter