From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbbCKDS5 (ORCPT ); Tue, 10 Mar 2015 23:18:57 -0400 Received: from arcturus.aphlor.org ([188.246.204.175]:49201 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbbCKDSz (ORCPT ); Tue, 10 Mar 2015 23:18:55 -0400 Date: Tue, 10 Mar 2015 23:18:48 -0400 From: Dave Jones To: Michael Ellerman Cc: linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com, mmarek@suse.cz, linux-api@vger.kernel.org Subject: Re: [PATCH 2/9] selftests: Add install target Message-ID: <20150311031848.GA7763@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Michael Ellerman , linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com, mmarek@suse.cz, linux-api@vger.kernel.org References: <1425358302-16680-1-git-send-email-mpe@ellerman.id.au> <1425358302-16680-2-git-send-email-mpe@ellerman.id.au> <20150305185326.GA30620@codemonkey.org.uk> <1426043710.23148.1.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426043710.23148.1.camel@ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Report: Spam report generated by SpamAssassin on "arcturus.aphlor.org" Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Authenticated-User: davej@codemonkey.org.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 02:15:10PM +1100, Michael Ellerman wrote: > On Thu, 2015-03-05 at 13:53 -0500, Dave Jones wrote: > > $ ./all.sh > > -bash: ./all.sh: /bin/bash\n\n: bad interpreter: No such file or directory > > > > Removing the \n\n fixes it. > > > > > + echo "cd \$$ROOT\n" >> $(ALL_SCRIPT); \ > > > > ditto > > Weird, I don't see that. > > $ make install > $ head install/run_kselftest.sh > #!/bin/bash > > > cd $(dirname $0) > > > Does it depend on the shell? I guess none of the newlines are necessary so I'll > just remove them. Dunno, bash here too. Maybe the version ? My environment at the office is a little dated. (It's based on ye olde ubuntu lts) Dave