From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbbCKH6L (ORCPT ); Wed, 11 Mar 2015 03:58:11 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:45664 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbbCKH6I (ORCPT ); Wed, 11 Mar 2015 03:58:08 -0400 Date: Wed, 11 Mar 2015 10:57:43 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] staging: sm750fb: correct integer comparison Message-ID: <20150311075743.GS10964@mwanda> References: <1426007817-1884-1-git-send-email-sudipm.mukherjee@gmail.com> <1426007817-1884-7-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426007817-1884-7-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 10:46:57PM +0530, Sudip Mukherjee wrote: > fixed the build warning about comparison of pointer and integer. > end of string was being compared to NULL. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/sm750fb/sm750.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 021b863..5532a28 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -1000,7 +1000,7 @@ static void sm750fb_setup(struct lynx_share * share,char * src) > goto NO_PARAM; > } > > - while((opt = strsep(&src,":")) != NULL && *opt != NULL){ > + while((opt = strsep(&src,":")) != NULL && *opt != 0){ Use '\0' for the NUL char. regards, dan carpenter