From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbbCKIqE (ORCPT ); Wed, 11 Mar 2015 04:46:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41689 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbbCKIp7 (ORCPT ); Wed, 11 Mar 2015 04:45:59 -0400 Date: Wed, 11 Mar 2015 11:45:38 +0300 From: Dan Carpenter To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro Message-ID: <20150311084538.GT10964@mwanda> References: <1426015760-8492-1-git-send-email-giedrius.statkevicius@gmail.com> <1426015760-8492-2-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426015760-8492-2-git-send-email-giedrius.statkevicius@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote: > static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf) > { > - struct dgnc_board *bd; > - int count = 0; > - int i = 0; > - > - DGNC_VERIFY_BOARD(p, bd); > + int count = 0, i = 0; Don't redo the patch, but really these should be on separate lines. This is an unwritten rule. :) Also there is no need to set "i". regards, dan carpenter