From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbbCKI4Z (ORCPT ); Wed, 11 Mar 2015 04:56:25 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47478 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964AbbCKI4U (ORCPT ); Wed, 11 Mar 2015 04:56:20 -0400 Date: Wed, 11 Mar 2015 11:56:04 +0300 From: Dan Carpenter To: Lorenzo Stoakes Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally Message-ID: <20150311085604.GV10964@mwanda> References: <1426037325-8392-1-git-send-email-lstoakes@gmail.com> <1426037325-8392-4-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426037325-8392-4-git-send-email-lstoakes@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 01:28:43AM +0000, Lorenzo Stoakes wrote: > This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver, > but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:- > > drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? > Just delete it. regards, dan carpenter