From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbbCKJhj (ORCPT ); Wed, 11 Mar 2015 05:37:39 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35820 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbbCKJhf (ORCPT ); Wed, 11 Mar 2015 05:37:35 -0400 Date: Wed, 11 Mar 2015 15:07:28 +0530 From: Sudip Mukherjee To: Lorenzo Stoakes Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally Message-ID: <20150311093728.GD4560@sudip-PC> References: <1426037325-8392-1-git-send-email-lstoakes@gmail.com> <1426037325-8392-4-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426037325-8392-4-git-send-email-lstoakes@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 01:28:43AM +0000, Lorenzo Stoakes wrote: > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 4aa763b..6521c3b 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -92,7 +92,7 @@ void hw_set2dformat(struct lynx_accel * accel,int fmt) > /* seems sm712 RectFill command is broken,so need use BitBlt to > * replace it. */ > > -static int hw712_fillrect(struct lynx_accel * accel, > +int hw712_fillrect(struct lynx_accel * accel, > u32 base,u32 pitch,u32 Bpp, > u32 x,u32 y,u32 width,u32 height, > u32 color,u32 rop) in your previous patch 3/6 you made it static now you are again removing the static keyword. may i ask why you changed it in 3/6 if you again change it back to original in this patch? anyways, like Dan said, delete this function, its not used anywhere. it will not be used also, i missed removing this function from the vendor crude drver. regards sudip >