From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext
Date: Wed, 11 Mar 2015 13:32:33 +0100 [thread overview]
Message-ID: <20150311123233.GE16419@pd.tnic> (raw)
In-Reply-To: <CALCETrXwVjHoOiH_LBpnZfbAGbBUMLM0V1-HtcwQbYNiGZ+-9g@mail.gmail.com>
On Wed, Mar 11, 2015 at 05:22:48AM -0700, Andy Lutomirski wrote:
> Wait... It looks like it really was saving them. Of course, this is
Bah, of course. Blind me.
> IOW, in 2.5.63 and earlier, we tried to save and restore TLS state
> across signals, but we did it wrong and would corrupt it for any
> program that used arch_prctl. At that time, programs could switch
> userspace threads using signals and their TLS pointers would switch.
> In 2.5.64 and later, we broke set_thread_area users, fixed arch_prctl
That is probably non-issue as 2.5 was the devel branch anyway in the old
days. I'm not sure what the statement on breaking ABI was though then...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-03-11 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 14:03 [PATCH v2 0/2] x86_64: Sigcontext improvements Andy Lutomirski
2015-03-10 14:03 ` [PATCH v2 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs Andy Lutomirski
2015-03-10 14:22 ` Andy Lutomirski
2015-03-10 16:42 ` Oleg Nesterov
2015-03-10 17:35 ` Andy Lutomirski
2015-03-11 8:31 ` Borislav Petkov
2015-03-12 20:38 ` Andy Lutomirski
2015-03-10 14:03 ` [PATCH v2 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext Andy Lutomirski
2015-03-10 14:22 ` Andy Lutomirski
2015-03-10 16:16 ` John Stoffel
2015-03-10 18:12 ` Andy Lutomirski
2015-03-11 9:28 ` Borislav Petkov
2015-03-11 12:22 ` Andy Lutomirski
2015-03-11 12:32 ` Borislav Petkov [this message]
2015-03-10 14:05 ` [PATCH v2 0/2] x86_64: Sigcontext improvements Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311123233.GE16419@pd.tnic \
--to=bp@alien8.de \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox