From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbbCKOOo (ORCPT ); Wed, 11 Mar 2015 10:14:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:49862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbbCKOMu (ORCPT ); Wed, 11 Mar 2015 10:12:50 -0400 Date: Wed, 11 Mar 2015 11:12:58 -0300 From: Arnaldo Carvalho de Melo To: He Kuang Cc: namhyung@kernel.org, a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, jolsa@kernel.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/2] perf hists browser: Fix UI bug after zoom into thread/dso/symbol Message-ID: <20150311141258.GG29070@kernel.org> References: <20150311002617.GG943@sejong> <1426077363-855-1-git-send-email-hekuang@huawei.com> <1426077363-855-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426077363-855-2-git-send-email-hekuang@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 11, 2015 at 08:36:03PM +0800, He Kuang escreveu: > When zoom into thread/dso/symbol, the fold/unfold stat is cleared in > hists__filter_by_thread/dso/symbol(), but h->nr_rows is not cleared. So > if we toggle fold stat on the unfold entires, nr_entries got a wrong > value. > > This bug can be reproduced as follows: > > $ perf record -g -e syscalls:sys_enter_open ls > $ perf report Thanks, bug reproduced and seems fixed after the patch, applying, - Arnaldo > Children Self Command Shared Object Symbol > ================================================================ > + 50.00% 0.00% ls ld64.so [.] _dl_get_ready_to_run > - 50.00% 0.00% ls ld64.so [.] _dl_load_shared_library > _dl_load_shared_library <= [Zoom into thread/dso] > _dl_get_ready_to_run > _start > ... > > In the new thread hists, all entries reset to fold, if we unfold the > same entry as we previously unfolded, nr_entries got wrong value, and we > can't move down cursor to bottom row. > > Thread: ls > Children Self Command Shared Object Symbol > ================================================================ > + 50.00% 0.00% ls ld64.so [.] _dl_get_ready_to_run > - 50.00% 0.00% ls ld64.so [.] _dl_load_shared_library > _dl_load_shared_library > _dl_get_ready_to_run <= [cursor may stop here, can't move down] > _start > ... > > This patch clear h->nr_rows to fix this bug. > > Signed-off-by: He Kuang > --- > tools/perf/util/hist.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 70b48a6..24aff7d 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -1169,6 +1169,7 @@ static void hists__remove_entry_filter(struct hists *hists, struct hist_entry *h > /* force fold unfiltered entry for simplicity */ > h->ms.unfolded = false; > h->row_offset = 0; > + h->nr_rows = 0; > > hists->stats.nr_non_filtered_samples += h->stat.nr_events; > > -- > 2.2.0.33.gc18b867