From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbCKOUJ (ORCPT ); Wed, 11 Mar 2015 10:20:09 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:42017 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbbCKOUH (ORCPT ); Wed, 11 Mar 2015 10:20:07 -0400 Date: Wed, 11 Mar 2015 15:20:24 +0100 From: Christoffer Dall To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH] KVM: arm/arm64: prefer IS_ENABLED to a static variable Message-ID: <20150311142024.GA23478@cbox> References: <1425554766-4119-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425554766-4119-1-git-send-email-pbonzini@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 12:26:06PM +0100, Paolo Bonzini wrote: > IS_ENABLED gives compile-time checking and keeps the code clearer. > > The one exception is inside kvm_vm_ioctl_check_extension, where > the established idiom is to wrap the case labels with an #ifdef. > > Signed-off-by: Paolo Bonzini Thanks, I've applied this to my queue with a follow-up to remove config options all together just like we have it on arm64. I'll send out that patch based on yours and I've applied Eric's IRQFD series on top of that. Best, -Christoffer