From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 1/6] zram: remove `num_migrated' device attr
Date: Thu, 12 Mar 2015 10:16:44 +0900 [thread overview]
Message-ID: <20150312011643.GA10820@blaptop> (raw)
In-Reply-To: <1426000114-4471-2-git-send-email-sergey.senozhatsky@gmail.com>
On Wed, Mar 11, 2015 at 12:08:29AM +0900, Sergey Senozhatsky wrote:
> Remove sysfs `num_migrated' attribute. We are moving away from
> per-stat device attrs towards 3 stat files that will accumulate
> io and mm stats in a format similar to block layer statistics in
> /sys/block/<dev>/stat. That will be easier to use in user space,
> and reduce the number of syscalls needed to read zram device
> statistics.
>
> `num_migrated' will return back in zram<id>/mm_stat file.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
> ---
> Documentation/ABI/testing/sysfs-block-zram | 7 -------
> drivers/block/zram/zram_drv.c | 2 --
> 2 files changed, 9 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram
> index bede902..91ad707 100644
> --- a/Documentation/ABI/testing/sysfs-block-zram
> +++ b/Documentation/ABI/testing/sysfs-block-zram
> @@ -149,10 +149,3 @@ Description:
> The compact file is write-only and trigger compaction for
> allocator zrm uses. The allocator moves some objects so that
> it could free fragment space.
> -
> -What: /sys/block/zram<id>/num_migrated
> -Date: August 2015
> -Contact: Minchan Kim <minchan@kernel.org>
> -Description:
> - The compact file is read-only and shows how many object
^^^^^
Argh, I believe you will correct it in later patch.
Thanks.
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2015-03-12 1:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 15:08 [PATCH 0/6] new zram statistics reporting scheme Sergey Senozhatsky
2015-03-10 15:08 ` [PATCH 1/6] zram: remove `num_migrated' device attr Sergey Senozhatsky
2015-03-12 1:16 ` Minchan Kim [this message]
2015-03-12 1:22 ` Sergey Senozhatsky
2015-03-10 15:08 ` [PATCH 2/6] zram: move compact_store() to sysfs functions area Sergey Senozhatsky
2015-03-12 1:24 ` Minchan Kim
2015-03-10 15:08 ` [PATCH 3/6] zram: use generic start/end io accounting Sergey Senozhatsky
2015-03-12 1:25 ` Minchan Kim
2015-03-10 15:08 ` [PATCH 4/6] zram: describe device attrs in documentation Sergey Senozhatsky
2015-03-12 1:33 ` Minchan Kim
2015-03-12 1:47 ` Sergey Senozhatsky
2015-03-10 15:08 ` [PATCH 5/6] zram: export new 'io_stat' sysfs attrs Sergey Senozhatsky
2015-03-12 1:36 ` Minchan Kim
2015-03-10 15:08 ` [PATCH 6/6] zram: export new 'mm_stat' " Sergey Senozhatsky
2015-03-12 1:41 ` Minchan Kim
2015-03-12 1:54 ` Sergey Senozhatsky
2015-03-12 1:55 ` [PATCH 0/6] new zram statistics reporting scheme Minchan Kim
2015-03-12 2:16 ` Sergey Senozhatsky
2015-03-12 5:03 ` Sergey Senozhatsky
2015-03-12 5:11 ` Minchan Kim
2015-03-12 5:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312011643.GA10820@blaptop \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox