From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbCLBQz (ORCPT ); Wed, 11 Mar 2015 21:16:55 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:42908 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbCLBQx (ORCPT ); Wed, 11 Mar 2015 21:16:53 -0400 Date: Thu, 12 Mar 2015 10:16:44 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/6] zram: remove `num_migrated' device attr Message-ID: <20150312011643.GA10820@blaptop> References: <1426000114-4471-1-git-send-email-sergey.senozhatsky@gmail.com> <1426000114-4471-2-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426000114-4471-2-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 12:08:29AM +0900, Sergey Senozhatsky wrote: > Remove sysfs `num_migrated' attribute. We are moving away from > per-stat device attrs towards 3 stat files that will accumulate > io and mm stats in a format similar to block layer statistics in > /sys/block//stat. That will be easier to use in user space, > and reduce the number of syscalls needed to read zram device > statistics. > > `num_migrated' will return back in zram/mm_stat file. > > Signed-off-by: Sergey Senozhatsky Acked-by: Minchan Kim > --- > Documentation/ABI/testing/sysfs-block-zram | 7 ------- > drivers/block/zram/zram_drv.c | 2 -- > 2 files changed, 9 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram > index bede902..91ad707 100644 > --- a/Documentation/ABI/testing/sysfs-block-zram > +++ b/Documentation/ABI/testing/sysfs-block-zram > @@ -149,10 +149,3 @@ Description: > The compact file is write-only and trigger compaction for > allocator zrm uses. The allocator moves some objects so that > it could free fragment space. > - > -What: /sys/block/zram/num_migrated > -Date: August 2015 > -Contact: Minchan Kim > -Description: > - The compact file is read-only and shows how many object ^^^^^ Argh, I believe you will correct it in later patch. Thanks. -- Kind regards, Minchan Kim