From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbbCLBmH (ORCPT ); Wed, 11 Mar 2015 21:42:07 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:37646 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbbCLBmF (ORCPT ); Wed, 11 Mar 2015 21:42:05 -0400 Date: Thu, 12 Mar 2015 10:41:57 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 6/6] zram: export new 'mm_stat' sysfs attrs Message-ID: <20150312014157.GF10820@blaptop> References: <1426000114-4471-1-git-send-email-sergey.senozhatsky@gmail.com> <1426000114-4471-7-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426000114-4471-7-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 12:08:34AM +0900, Sergey Senozhatsky wrote: > Per-device `zram/mm_stat' file provides accumulated mm statistics > of particular zram device in a format similar to block layer statistics. > The file consists of a single line and represents the following stats > (separated by whitespace): > orig_data_size > compr_data_size > mem_used_total > mem_limit > mem_used_max > zero_pages > num_migrated > > Since now we have three stat files (block layer zram/stat, > zram/io_stat and zram/mm_stat) document WARNING about > per-stat sysfs nodes being deprecated. Any user doesn't take care of document. I think we should add pr_warn_once to notify the user if he tried deprecated interface. In addition, we should add deprecated interface in Documentation/ABI/obsolete/ > > Signed-off-by: Sergey Senozhatsky > --- > Documentation/ABI/testing/sysfs-block-zram | 8 ++++++++ > Documentation/blockdev/zram.txt | 18 +++++++++++++++++ > drivers/block/zram/zram_drv.c | 31 ++++++++++++++++++++++++++++++ > 3 files changed, 57 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram > index a7f622f..8114c81 100644 > --- a/Documentation/ABI/testing/sysfs-block-zram > +++ b/Documentation/ABI/testing/sysfs-block-zram > @@ -158,3 +158,11 @@ Description: > statistics not accounted by block layer. For example, > failed_reads, failed_writes, etc. File format is similar to > block layer statistics file format. > + > +What: /sys/block/zram/mm_stat > +Date: August 2015 > +Contact: Sergey Senozhatsky > +Description: > + The mm_stat file is read-only and accumulates device's mm > + statistics (orig_data_size, compr_data_size, etc.) in a format Every field in mm_stat doesn't mean accumulation. -- Kind regards, Minchan Kim