From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbbCLByJ (ORCPT ); Wed, 11 Mar 2015 21:54:09 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:46403 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbCLByG (ORCPT ); Wed, 11 Mar 2015 21:54:06 -0400 Date: Thu, 12 Mar 2015 10:54:11 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 6/6] zram: export new 'mm_stat' sysfs attrs Message-ID: <20150312015411.GB948@swordfish> References: <1426000114-4471-1-git-send-email-sergey.senozhatsky@gmail.com> <1426000114-4471-7-git-send-email-sergey.senozhatsky@gmail.com> <20150312014157.GF10820@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150312014157.GF10820@blaptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (03/12/15 10:41), Minchan Kim wrote: > Any user doesn't take care of document. I think we should add > pr_warn_once to notify the user if he tried deprecated interface. yes, that was something I didn't want to include into this patch. I agree that some sort of a warning should go into the logs. do you want me to add pr_warn_once() to every _show() function? having this in documentation will not do any harm, so let's keep it there as well. > In addition, we should add deprecated interface in Documentation/ABI/obsolete/ > didn't know about that. ok, will send "deprecate old attrs" patch that will add deprecated attrs to Documentation/ABI/obsolete/ and add pr_warn_once(). > > > > Signed-off-by: Sergey Senozhatsky > > --- > > Documentation/ABI/testing/sysfs-block-zram | 8 ++++++++ > > Documentation/blockdev/zram.txt | 18 +++++++++++++++++ > > drivers/block/zram/zram_drv.c | 31 ++++++++++++++++++++++++++++++ > > 3 files changed, 57 insertions(+) > > > > diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram > > index a7f622f..8114c81 100644 > > --- a/Documentation/ABI/testing/sysfs-block-zram > > +++ b/Documentation/ABI/testing/sysfs-block-zram > > @@ -158,3 +158,11 @@ Description: > > statistics not accounted by block layer. For example, > > failed_reads, failed_writes, etc. File format is similar to > > block layer statistics file format. > > + > > +What: /sys/block/zram/mm_stat > > +Date: August 2015 > > +Contact: Sergey Senozhatsky > > +Description: > > + The mm_stat file is read-only and accumulates device's mm > > + statistics (orig_data_size, compr_data_size, etc.) in a format > > Every field in mm_stat doesn't mean accumulation. > agree. bad wording. only num_migrated shows the accumulated number. will send a trivial patch later. -ss