From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbbCLCQJ (ORCPT ); Wed, 11 Mar 2015 22:16:09 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:39473 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbbCLCQD (ORCPT ); Wed, 11 Mar 2015 22:16:03 -0400 Date: Thu, 12 Mar 2015 11:16:09 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 0/6] new zram statistics reporting scheme Message-ID: <20150312021609.GA3508@swordfish> References: <1426000114-4471-1-git-send-email-sergey.senozhatsky@gmail.com> <20150312015558.GG10820@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150312015558.GG10820@blaptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (03/12/15 10:55), Minchan Kim wrote: > I really appreciate you enhance stat functions, esp, working with iostat! thanks! my pleasure. > One thing I want to discuss is sometime we could remove RO fields > in /sys/block/zram/ but we couldn't remove RW fields because > io_stat/mm_stat doesn't have any writable option now so users will > have two options to read stat. For exmaple, I played with CONFIG_ZRAM_OLD_STATS option, which turns RW attrs into WO attrs (where possible/needed). but it turned out to be a rather ugly patch and I eventually decided that I don't want to have these #ifdef-s in zram code for the next two years. so providing both RW/RO old stats (with a warning in the logs) and RO [mm|io]_stat sound like a better plan. > cat /sys/block/zram/mem_used_max > cat /sys/block/zram/mm_stat | awk friend > > How about changing only writeable, not readable for duplicated stats > in /sys/block/zram? So, user will have writeable stat to set some > options in /sys/block/zram and readable stat to get some data in > /sys/block/zram/[io|mm]_stat if the stat is duplicated in both. Sorry, I probably didn't drink enough coffee today, can you please rephrase or give a trivial example? -ss