From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbbCLDmj (ORCPT ); Wed, 11 Mar 2015 23:42:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37689 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbbCLDmg (ORCPT ); Wed, 11 Mar 2015 23:42:36 -0400 Date: Wed, 11 Mar 2015 20:42:34 -0700 From: Kenneth Westfield To: Stephen Boyd Cc: Mike Turquette , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kenneth Westfield Subject: Re: [PATCH v2] clk: qcom: Properly change rates for ahbix clock Message-ID: <20150312034234.GA22530@kwestfie-linux.qualcomm.com> Mail-Followup-To: Kenneth Westfield , Stephen Boyd , Mike Turquette , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1425685313-6005-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425685313-6005-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2015 at 03:41:53PM -0800, Stephen Boyd wrote: > The ahbix clock can never be turned off in practice. To change the > rates we need to switch the mux off the M/N counter to an always on > source (XO), reprogram the M/N counter to get the rate we want and > finally switch back to the M/N counter. Add a new ops structure > for this type of clock so that we can set the rate properly. > > Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC) driver" > Cc: Kenneth Westfield > Signed-off-by: Stephen Boyd > --- > > Changes from v1: > * Handle the case where clock feeding M/N counter is off > > drivers/clk/qcom/clk-rcg.c | 62 ++++++++++++++++++++++++++++++++++++++++++ > drivers/clk/qcom/clk-rcg.h | 1 + > drivers/clk/qcom/lcc-ipq806x.c | 5 ++-- > 3 files changed, 65 insertions(+), 3 deletions(-) Verified I2S audio functionality on the Storm board; with and without firmware audio enabled. Tested-by: Kenneth Westfield -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project