From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbbCLHAX (ORCPT ); Thu, 12 Mar 2015 03:00:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:53065 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbbCLHAU (ORCPT ); Thu, 12 Mar 2015 03:00:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,387,1422950400"; d="scan'208";a="466158009" Date: Thu, 12 Mar 2015 14:42:10 +0800 From: Wanpeng Li To: Chao Yu Cc: "'Wanpeng Li'" , "'Jaegeuk Kim'" , "'Changman Lee'" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] f2fs: add fast symlink Message-ID: <20150312064210.GA12364@kernel> Reply-To: Wanpeng Li References: <1426074741-31296-1-git-send-email-wanpeng.li@linux.intel.com> <009d01d05c7b$950dd970$bf298c50$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <009d01d05c7b$950dd970$bf298c50$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, On Thu, Mar 12, 2015 at 12:17:29PM +0800, Chao Yu wrote: > >We always remain space in inode page for inline xattr data, >so it's better to define our max size of fast symlink as below: > >#define MAX_FAST_SYMLINK_SIZE (MAX_INLINE_DATA + 1) > Thanks for your review, I just handle all your comments and it works well. Btw, one question, if inline xattr data area is reserved in inode even if it isn't mounted w/ inline_xattr option? If yes, why it is reserved? Regards, Wanpeng Li