From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbbCLJDR (ORCPT ); Thu, 12 Mar 2015 05:03:17 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33843 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222AbbCLJDO (ORCPT ); Thu, 12 Mar 2015 05:03:14 -0400 Date: Thu, 12 Mar 2015 09:03:08 +0000 From: Lee Jones To: Scott Wood Cc: trivial@kernel.org, linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 16/22] mfd: %pF is only for function pointers Message-ID: <20150312090308.GD3314@x1> References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-16-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426130037-17956-16-git-send-email-scottwood@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2015, Scott Wood wrote: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. > > Signed-off-by: Scott Wood > Cc: Samuel Ortiz > Cc: Lee Jones > --- > drivers/mfd/mc13xxx-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c > index 64dde5d..25fd711 100644 > --- a/drivers/mfd/mc13xxx-core.c > +++ b/drivers/mfd/mc13xxx-core.c > @@ -51,19 +51,19 @@ > void mc13xxx_lock(struct mc13xxx *mc13xxx) > { > if (!mutex_trylock(&mc13xxx->lock)) { > - dev_dbg(mc13xxx->dev, "wait for %s from %pf\n", > + dev_dbg(mc13xxx->dev, "wait for %s from %ps\n", > __func__, __builtin_return_address(0)); > > mutex_lock(&mc13xxx->lock); > } > - dev_dbg(mc13xxx->dev, "%s from %pf\n", > + dev_dbg(mc13xxx->dev, "%s from %ps\n", > __func__, __builtin_return_address(0)); > } > EXPORT_SYMBOL(mc13xxx_lock); > > void mc13xxx_unlock(struct mc13xxx *mc13xxx) > { > - dev_dbg(mc13xxx->dev, "%s from %pf\n", > + dev_dbg(mc13xxx->dev, "%s from %ps\n", > __func__, __builtin_return_address(0)); > mutex_unlock(&mc13xxx->lock); > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog