From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753269AbbCLJu0 (ORCPT ); Thu, 12 Mar 2015 05:50:26 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:41596 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbbCLJuY (ORCPT ); Thu, 12 Mar 2015 05:50:24 -0400 Date: Thu, 12 Mar 2015 09:50:18 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Jiri Kosina , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org Subject: Re: [RESEND PATCH v6 09/22] mfd: ab8500: Use power_supply_*() API for accessing function attrs Message-ID: <20150312095017.GE3314@x1> References: <1426146260-30081-1-git-send-email-k.kozlowski@samsung.com> <1426146260-30081-10-git-send-email-k.kozlowski@samsung.com> <20150312090156.GB3314@x1> <1426152267.31959.1.camel@AMDC1943> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426152267.31959.1.camel@AMDC1943> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Mar 2015, Krzysztof Kozlowski wrote: > On czw, 2015-03-12 at 09:01 +0000, Lee Jones wrote: > > On Thu, 12 Mar 2015, Krzysztof Kozlowski wrote: > > > > > Replace direct calls to power supply function attributes with wrappers. > > > Wrappers provide safe access in case of unregistering the power > > > supply (e.g. by removing the driver). Replace: > > > - get_property -> power_supply_get_property > > > > > > Signed-off-by: Krzysztof Kozlowski > > > Acked-by: Jonghwa Lee > > > Acked-by: Pavel Machek > > > Acked-by: Lee Jones > > > Reviewed-by: Bartlomiej Zolnierkiewicz > > > Reviewed-by: Sebastian Reichel > > > --- > > > drivers/mfd/ab8500-sysctrl.c | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > Has the infrastructure for these been merged yet? > > > > I.e. Can I just take them? > > Previous patches were not merged yet so you cannot take it. This whole > patchset can be applied incrementally but cherry picking won't work. So I only usually receive patches I've already Acked when a) the bulk of the set has been merged and I can apply the remaining lingerers, or b) the whole set is due to be applied through the MFD tree. Receiving 2 patches of a 22 patch set, which I have already Acked and that I can't pick is unwelcome noise. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog