From: Greg KH <gregkh@linuxfoundation.org>
To: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro
Date: Thu, 12 Mar 2015 11:13:25 +0100 [thread overview]
Message-ID: <20150312101325.GA6897@kroah.com> (raw)
In-Reply-To: <1426015760-8492-2-git-send-email-giedrius.statkevicius@gmail.com>
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
> In sysfs methods struct device is guaranteed to not be NULL thus bd will
> not be NULL in any way. Also, checking for bd->magic != DGNC_BOARD_MAGIC
> and bd->state != BOARD_READY is redundant because we already don't
> initialize broken boards since "dgnc: Don't save boards in memory that
> have failed to initialize" and make sysfs files after initializing the
> board in dgnc_driver.c or IOW they are already set for successfully
> initialized boards before their sysfs files created (412 and 593 lines
> in dgnc_driver.c).
As I didn't take your previous patch that this relies on, I can't take
this one at this point in time, sorry.
greg k-h
next prev parent reply other threads:[~2015-03-12 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 19:29 [PATCH 1/3] dgnc: Remove unneeded dgnc_state array of strings Giedrius Statkevičius
2015-03-10 19:29 ` [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro Giedrius Statkevičius
2015-03-11 8:45 ` Dan Carpenter
2015-03-12 10:13 ` Greg KH [this message]
2015-03-10 19:29 ` [PATCH 3/3] dgnc: clean up comments at start of files Giedrius Statkevičius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312101325.GA6897@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=giedrius.statkevicius@gmail.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox