From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbbCLKNa (ORCPT ); Thu, 12 Mar 2015 06:13:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33679 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbbCLKN3 (ORCPT ); Thu, 12 Mar 2015 06:13:29 -0400 Date: Thu, 12 Mar 2015 11:13:25 +0100 From: Greg KH To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro Message-ID: <20150312101325.GA6897@kroah.com> References: <1426015760-8492-1-git-send-email-giedrius.statkevicius@gmail.com> <1426015760-8492-2-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426015760-8492-2-git-send-email-giedrius.statkevicius@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote: > In sysfs methods struct device is guaranteed to not be NULL thus bd will > not be NULL in any way. Also, checking for bd->magic != DGNC_BOARD_MAGIC > and bd->state != BOARD_READY is redundant because we already don't > initialize broken boards since "dgnc: Don't save boards in memory that > have failed to initialize" and make sysfs files after initializing the > board in dgnc_driver.c or IOW they are already set for successfully > initialized boards before their sysfs files created (412 and 593 lines > in dgnc_driver.c). As I didn't take your previous patch that this relies on, I can't take this one at this point in time, sorry. greg k-h