From: Dan Carpenter <dan.carpenter@oracle.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
apw@canonical.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure
Date: Thu, 12 Mar 2015 14:41:01 +0300 [thread overview]
Message-ID: <20150312114101.GB10964@mwanda> (raw)
In-Reply-To: <20150312111428.GA17163@aepfle.de>
On Thu, Mar 12, 2015 at 12:14:28PM +0100, Olaf Hering wrote:
> On Thu, Mar 12, Vitaly Kuznetsov wrote:
>
> > My "Drivers: hv: hv_balloon: eliminate the trylock path in
> > acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa
> > in char-misc-next) removed these wrappers.
>
> I see now. There are many changes in char-misc-next. The description
> gives the impression that mainline is broken. Not sure if thats true,
> perhaps its just char-misc-next which is affected.
Mainline is broken. We only found these when we removed the wrapper and
then static checkers were able to catch the bug.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-12 11:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 1:55 [PATCH 0/6] drivers: hv: vmbus: Some miscellaneous fixes for Linux 4.0 K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 1/6] Drivers: hv: vmbus: Perform device register in the per-channel work element K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure K. Y. Srinivasan
2015-03-12 10:45 ` Olaf Hering
2015-03-12 10:53 ` Vitaly Kuznetsov
2015-03-12 11:14 ` Olaf Hering
2015-03-12 11:41 ` Dan Carpenter [this message]
2015-03-12 12:44 ` KY Srinivasan
2015-03-12 1:56 ` [PATCH 3/6] Drivers: hv: hv_balloon: don't lose memory when onlining order is not natural K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 4/6] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 5/6] tools: hv: fcopy_daemon: support >2GB files for x86_32 guest K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 6/6] Drivers: hv: vmbus: Fix a bug in rescind processing in vmbus_close_internal() K. Y. Srinivasan
2015-03-12 9:02 ` [PATCH 1/6] Drivers: hv: vmbus: Perform device register in the per-channel work element Greg KH
2015-03-12 9:03 ` Greg KH
2015-03-12 13:12 ` KY Srinivasan
2015-03-12 13:28 ` Greg KH
2015-03-12 14:16 ` KY Srinivasan
2015-03-16 20:22 ` Greg KH
2015-03-16 21:09 ` KY Srinivasan
2015-03-17 4:50 ` KY Srinivasan
2015-03-12 10:44 ` Olaf Hering
2015-03-12 14:28 ` KY Srinivasan
2015-03-12 16:09 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312114101.GB10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox