From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752870AbbCLSxl (ORCPT ); Thu, 12 Mar 2015 14:53:41 -0400 Received: from mx-guillaumet.finsecur.com ([91.217.234.131]:36513 "EHLO guillaumet.finsecur.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbbCLSxk (ORCPT ); Thu, 12 Mar 2015 14:53:40 -0400 Date: Thu, 12 Mar 2015 19:53:36 +0100 From: Sylvain Rochet To: Wenyou Yang Cc: nicolas.ferre@atmel.com, linux@maxim.org.za, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, patrice.vilchez@atmel.com, sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com Message-ID: <20150312185336.GA30371@gradator.net> References: <1423709123-8033-1-git-send-email-wenyou.yang@atmel.com> <1423709209-8108-1-git-send-email-wenyou.yang@atmel.com> <20150306232224.GA7475@gradator.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150306232224.GA7475@gradator.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 172.16.8.13 X-SA-Exim-Mail-From: sylvain.rochet@finsecur.com Subject: Re: [PATCH 2/6] pm: at91: move the copying the sram function to the sram initializationi phase X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on guillaumet.finsecur.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Wenyou, On Sat, Mar 07, 2015 at 12:22:24AM +0100, Sylvain Rochet wrote: > Hello Wenyou, > > On Thu, Feb 12, 2015 at 10:46:49AM +0800, Wenyou Yang wrote: > > To decrease the suspend time, move copying the sram function to the sram > > initialization phase, instead of every time go to suspend. > > > > In the meanwhile, substitute fncpy() for memcpy(). > > > > If there is no sram allocated for PM, the PM is not supported. > > My board doesn't boot anymore with this change, I am not equipped enough > to debug more, looks like fncpy() is writing the function on top of > existing kernel code. > > You said you had issues with fncpy(), I guess I am having the issue you > had. A make clean later, it works… sorry for the mess. Sylvain