From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbbCLS7k (ORCPT ); Thu, 12 Mar 2015 14:59:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:16585 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbbCLS7g (ORCPT ); Thu, 12 Mar 2015 14:59:36 -0400 Date: Thu, 12 Mar 2015 21:59:15 +0300 From: Dan Carpenter To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] dgnc: convert TRUE/FALSE #defines to 1/0 Message-ID: <20150312185915.GC10964@mwanda> References: <1426184068-5772-1-git-send-email-giedrius.statkevicius@gmail.com> <1426184068-5772-3-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426184068-5772-3-git-send-email-giedrius.statkevicius@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 08:14:25PM +0200, Giedrius Statkevičius wrote: > TRUE/FALSE defined in dgnc_types.h are only used in dgnc_tty.c thus it > would be better to just use 1/0 to avoid unnecessary extra files and > includes. > Use true/false. I don't care much about this personally but true/false is kernel style these days. regards, dan carpenter